Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links #6194

Closed
dveeden opened this issue Aug 20, 2021 · 2 comments · Fixed by #6196
Closed

Broken links #6194

dveeden opened this issue Aug 20, 2021 · 2 comments · Fixed by #6196

Comments

@dveeden
Copy link
Contributor

dveeden commented Aug 20, 2021

Error Report

#!/bin/sh

http_status_ok="0,200,400,403,429,999"

find . -type f -name "*\.md" -exec /usr/local/bin/markdown-link-check -q -a $http_status_ok {} \; 2> /dev/null | awk '
/^FILE/ {
  file=$2
}

/→ Status: / {
  print file " - " $2 " → Status: " $NF
}
'

Result:

./tiup/tiup-dm-topology-reference.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/dm/topology.example.yaml → Status: 404
./tiup/tiup-cluster.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml → Status: 404
./tiup/tiup-cluster-topology-reference.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml → Status: 404
./error-codes.md - https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html → Status: 404
./maintain-tidb-using-tiup.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml → Status: 404
./support.md - https://pingcap.com/tidbslack → Status: 404
./production-deployment-using-tiup.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml → Status: 404
./production-deployment-using-tiup.md - https://github.com/pingcap/tiup/blob/master/embed/templates/examples/topology.example.yaml#L7 → Status: 404

This is excluding what was reported in #6192 and #6193

@dveeden
Copy link
Contributor Author

dveeden commented Aug 20, 2021

Most of these were fixed in #6153

[dvaneeden@dve-carbon docs]$ for p in ./tiup/tiup-dm-topology-reference.md ./tiup/tiup-cluster.md ./tiup/tiup-cluster-topology-reference.md ./maintain-tidb-using-tiup.md ./production-deployment-using-tiup.md; do /usr/local/bin/markdown-link-check -q -a 0,200,400,403,429,999 $p; done

FILE: ./tiup/tiup-dm-topology-reference.md

13 links checked.

FILE: ./tiup/tiup-cluster.md

8 links checked.

FILE: ./tiup/tiup-cluster-topology-reference.md

28 links checked.

FILE: ./maintain-tidb-using-tiup.md

5 links checked.

FILE: ./production-deployment-using-tiup.md

27 links checked.

@dveeden
Copy link
Contributor Author

dveeden commented Aug 20, 2021

But these are still there:

[dvaneeden@dve-carbon docs]$ for p in ./error-codes.md ./support.md ; do /usr/local/bin/markdown-link-check -q -a 0,200,400,403,429,999 $p; done


FILE: ./error-codes.md
[✖] https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html

17 links checked.

ERROR: 1 dead links found!
[✖] https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html → Status: 404

FILE: ./support.md
[✖] https://pingcap.com/tidbslack

8 links checked.

ERROR: 1 dead links found!
[✖] https://pingcap.com/tidbslack → Status: 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant