Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat the config file documentation format of DM, Lightning, TiCDC, TiFlash to the same as that of TiDB, TiKV, PD, TiProxy #19005

Open
8 tasks
kennytm opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
area/dm area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. type/enhancement The issue or PR belongs to an enhancement.

Comments

@kennytm
Copy link
Contributor

kennytm commented Sep 25, 2024

Change Request

Please answer the following questions before submitting your issue. Thanks!

  1. Describe what you find is inappropriate or missing in the existing docs.

The config doc of DM, Lightning, CDC and TiFlash mostly just the config template verbatim. The explanation of each config is either laid out as a table, or worse, as inline TOML/YAML comments. The problems are

  • Support engineers cannot easily link to a particular config item.
  • Due to the format, the documentation of each config item is usually constrained to a single paragraph
  • Inline comments are very difficult to read.
  1. Describe your suggestion or addition.

These documentation should align with the format chosen by TiDB, TiKV and PD etc, using one <h3> section for each config item and one <h2> for each group.

The content of each config item can show the default value, possible ranges. Each item can have the "New in vX.Y" showing the supported version range. The description itself can be formatted and link to other documentations (unlike inline comments). Caveats can be explained in details without worrying about <td> size.

  1. Provide some reference materials (such as documents and websites) if you could.

Config documentation which I consider bad:

Config documentation which are better:

@kennytm kennytm added area/dm area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. labels Sep 25, 2024
@qiancai qiancai added the type/enhancement The issue or PR belongs to an enhancement. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

5 participants