From 1594aa1293ee08794846b1f4e5aaf15db0b75ab9 Mon Sep 17 00:00:00 2001 From: xixirangrang Date: Fri, 8 Sep 2023 09:46:51 +0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Ran --- dm/dm-binlog-event-filter.md | 2 +- dm/dm-block-allow-table-lists.md | 2 +- dm/dm-table-routing.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dm/dm-binlog-event-filter.md b/dm/dm-binlog-event-filter.md index 35cd66eeea0d8..5bcc5d35bc240 100644 --- a/dm/dm-binlog-event-filter.md +++ b/dm/dm-binlog-event-filter.md @@ -25,7 +25,7 @@ Starting from DM v2.0.2, you can configure the binlog event filter in the source When you use the wildcard for matching schemas and tables, note the following: -- `schema-pattern` and `table-pattern` only support wildcards including `*`, `?` and `[]`. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. +- `schema-pattern` and `table-pattern` only support wildcards, including `*`, `?`, and `[]`. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. - `sql-pattern` only supports regular expressions. diff --git a/dm/dm-block-allow-table-lists.md b/dm/dm-block-allow-table-lists.md index fdcf6b04ae207..3c131d245e2ca 100644 --- a/dm/dm-block-allow-table-lists.md +++ b/dm/dm-block-allow-table-lists.md @@ -36,7 +36,7 @@ block-allow-list: # Use black-white-list if the DM version is earlie In simple scenarios, it is recommended that you use the wildcard for matching schemas and tables. However, note the following version differences: -- Wildcards including `*`, `?` and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `tbl-name: "t*"`, `"t*"` indicates all tables starting with `t`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. +- Wildcards including `*`, `?`, and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `tbl-name: "t*"`, `"t*"` indicates all tables starting with `t`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. - A regular expression must begin with the `~` character. diff --git a/dm/dm-table-routing.md b/dm/dm-table-routing.md index 16668200a4446..63f1089e56ef6 100644 --- a/dm/dm-table-routing.md +++ b/dm/dm-table-routing.md @@ -40,7 +40,7 @@ routes: Regular expressions and wildcards are supported to match database and table names. In simple scenarios, it is recommended that you use the wildcard for matching schemas and tables. However, note the following: -- Wildcards including `*`, `?` and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. +- Wildcards including `*`, `?`, and `[]` are supported. There can only be one `*` symbol in a wildcard match, and it must be at the end. For example, in `table-pattern: "t_*"`, `"t_*"` indicates all tables starting with `t_`. See [wildcard matching](https://en.wikipedia.org/wiki/Glob_(programming)#Syntax) for details. - `table-regexp`, `schema-regexp`, and `source-regexp` only support regular expressions and cannot start with the `~` symbol.