Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

some close of chan not handled correctly #960

Closed
csuzhangxc opened this issue Aug 31, 2020 · 0 comments · Fixed by #962
Closed

some close of chan not handled correctly #960

csuzhangxc opened this issue Aug 31, 2020 · 0 comments · Fixed by #962
Assignees
@lance6716
Labels
help wanted This issue wanted some help from contributor severity/major type/bug This issue is a bug report

Comments

@csuzhangxc
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

    stop DM-worker process.

  2. What did you expect to see?

    the process stopped.

  3. What did you see instead?

    image

    this may because not handle the close of errCh here (

    dm/dm/worker/server.go

    Line 371 in 7f7a501

    case err := <-errCh:
    ).

    but we should fix other places for the close of chan too.

  4. Versions of the cluster

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      v2.0.0-rc
@csuzhangxc csuzhangxc added type/bug This issue is a bug report help wanted This issue wanted some help from contributor labels Aug 31, 2020
@lance6716 lance6716 self-assigned this Aug 31, 2020
@lance6716 lance6716 mentioned this issue Aug 31, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Aug 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lance6716 lance6716

Labels
help wanted This issue wanted some help from contributor severity/major type/bug This issue is a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: check channel closed in select{} lance6716/dm
3 participants
@lance6716 @csuzhangxc @sre-bot