Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Too many empty regions during br-restore #964

Closed
cosven opened this issue Mar 30, 2021 · 4 comments · Fixed by tikv/tikv#9924
Closed

Too many empty regions during br-restore #964

cosven opened this issue Mar 30, 2021 · 4 comments · Fixed by tikv/tikv#9924

Comments

@cosven
Copy link

cosven commented Mar 30, 2021

Question

TiDB version is v4.0.11.

1. Restoring 2T tpcc data with 3pd 2db 4kv.

The br version is v4.0.11.

First time
image

Second time
image

2. Restoring 2T tpcc data with 1pd 1db 3kv.

The br version is v4.0.12(14d55a7)

Restore finished at 22:47:31.
image

3. Restoring 2T tpcc data with 1pd 1db 3kv.

The tikv config is

coprocessor.region-split-size: "48M"

The br version is v4.0.11
Restore finished at 03:11:30.
image

@cosven
Copy link
Author

cosven commented Mar 30, 2021

Re-run the first scene (3pd 2db 4kv + br v4.0.11 2t) with customized tikv config

coprocessor.region-split-size: "48M"

image
image

Note: I run the go-tpc tpcc run right after br-restore finished. I dont know if it affects the test result.
I think I also run the go-tpc tpcc run in the first scene, so I update the metrics screenshot for the first scene.

@YuJuncen
Copy link
Collaborator

YuJuncen commented Mar 31, 2021

After tikv/tikv#9924, this problem is mainly solved:

image

@cyliu0
Copy link

cyliu0 commented Apr 1, 2021

@cosven Is there anything bad happened yet because of this?
@YuJuncen @3pointer Could you please estimate the impact of this bug? Will this one lead to a performance decrease or service unavailable? Feel free to change the severity I just labeled.

@cosven
Copy link
Author

cosven commented Apr 2, 2021

Is there anything bad happened yet because of this?

Currently, no.

I think too many empty region has potential influence on tikv CPU usage and pd scheduling efficiency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants