Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Team model functionality to abstract and concrete classes #25

Closed
jacobwegner opened this issue Sep 9, 2015 · 1 comment · Fixed by #46
Closed

Split Team model functionality to abstract and concrete classes #25

jacobwegner opened this issue Sep 9, 2015 · 1 comment · Fixed by #46

Comments

@jacobwegner
Copy link
Contributor

Allow a:

  • Abstract base class (created by, created, member_access, manager_access)
  • Concrete class that implements the base class; no requirements for additional fields like name and slug
  • "Default" class for the app (that implements the additional fields currently on Team)

This approach would allow a developer to implement a subset of the current teams app in a project (that, for example, may not require a name or slug field), while maintaining compatibility would current functionality.

It would also make it easier to derive a custom class at the project level to store project-specific data on that custom model.

@jtauber
Copy link
Member

jtauber commented Feb 9, 2016

The concrete class with no additional fields could be called Role and the one WITH the additional fields could be called Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants