Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MICS6814 c implementation has the OX and RED pins defined the wrong way round #618

Closed
knightinlet opened this issue Jan 4, 2023 · 0 comments
Labels
[- breakout -] https://shop.pimoroni.com/collections/breakout-garden

Comments

@knightinlet
Copy link

Looks like the c implementation has the OX and RED pins defined the wrong way round.

breakout_mics6814.hpp has the values

static const uint8_t MICS_VREF        = 14;
static const uint8_t MICS_RED         = 12;
static const uint8_t MICS_NH3         = 11;
static const uint8_t MICS_OX          = 13;

whereas the python implementation

pimoroni/mics6814-python/library/mics6814/init.py

MICS6814_VREF = 14 # P1.4 AIN0 - 3v3
MICS6814_RED = 13 # P0.7 AIN2 - Reducing
MICS6814_NH3 = 11 # P0.6 AIN3 - NH3
MICS6814_OX = 12 # P0.5 AIN4 - Oxidizing

Looking at the component schematic it looks like the python implementation is correct.

@knightinlet knightinlet changed the title MICS6814 c implementation has the OX and RED pins define the wrong way round MICS6814 c implementation has the OX and RED pins defined the wrong way round Jan 4, 2023
@ZodiusInfuser ZodiusInfuser added the [- breakout -] https://shop.pimoroni.com/collections/breakout-garden label Jan 20, 2023
@thirdr thirdr closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[- breakout -] https://shop.pimoroni.com/collections/breakout-garden
Projects
None yet
Development

No branches or pull requests

3 participants