From 0bf63ca88196d6319d6fb0d5bc8b83be2c1f0964 Mon Sep 17 00:00:00 2001 From: Charlie Birks Date: Wed, 4 Dec 2024 14:17:13 +0000 Subject: [PATCH 1/2] hub75: don't enable an unrelated IRQ DREQs are not IRQs, `DREQ_PIO0_TXn` happens to align with `TIMER_IRQ_n` so this enabled a timer IRQ. --- drivers/hub75/hub75.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hub75/hub75.cpp b/drivers/hub75/hub75.cpp index a894b70df..0b0ffbf54 100644 --- a/drivers/hub75/hub75.cpp +++ b/drivers/hub75/hub75.cpp @@ -146,7 +146,6 @@ void Hub75::start(irq_handler_t handler) { dma_channel_set_irq0_enabled(dma_channel, true); - irq_set_enabled(pio_get_dreq(pio, sm_data, true), true); irq_set_enabled(DMA_IRQ_0, true); row = 0; @@ -275,4 +274,4 @@ void Hub75::update(PicoGraphics *graphics) { } } } -} \ No newline at end of file +} From e70c40b7064ffc88d7d4f8d80053f60e4edfaae3 Mon Sep 17 00:00:00 2001 From: Charlie Birks Date: Wed, 4 Dec 2024 16:07:37 +0000 Subject: [PATCH 2/2] hub75: also don't disable that IRQ --- drivers/hub75/hub75.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hub75/hub75.cpp b/drivers/hub75/hub75.cpp index 0b0ffbf54..2f2a48d62 100644 --- a/drivers/hub75/hub75.cpp +++ b/drivers/hub75/hub75.cpp @@ -160,7 +160,6 @@ void Hub75::start(irq_handler_t handler) { void Hub75::stop(irq_handler_t handler) { irq_set_enabled(DMA_IRQ_0, false); - irq_set_enabled(pio_get_dreq(pio, sm_data, true), false); if(dma_channel != -1 && dma_channel_is_claimed(dma_channel)) { dma_channel_set_irq0_enabled(dma_channel, false);