Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About duplicated anchors #810

Closed
Ducasse opened this issue Aug 2, 2024 · 1 comment
Closed

About duplicated anchors #810

Ducasse opened this issue Aug 2, 2024 · 1 comment
Assignees
Labels

Comments

@Ducasse
Copy link
Contributor

Ducasse commented Aug 2, 2024

We should not just create a result for the last occurrences of a duplicated anchor but for all of them. Else we will not be able to say to the user that anchor1 in file1 is duplicated with anchor2 in file2.

We should write a test to check if we report two results.

If we do not handle duplicated anchors well then the logic should be

  • add a result all the time
  • then check at the end to remove the uniquely defined ones from the results.
@Ducasse
Copy link
Contributor Author

Ducasse commented Aug 3, 2024

@melkiyasser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants