Try launching in external app first #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, hopefully this gets a look from the owner soon. |
|
@pikaju , can this be merged? |
LevisLuong
reviewed
Nov 27, 2024
| @@ -56,20 +56,33 @@ class MapsLauncher { | |||
| return uri; | |||
| } | |||
|
|
|||
| static Future<LaunchMode> _launchMode() async => | |||
| await supportsLaunchMode(LaunchMode.externalNonBrowserApplication) | |||
There was a problem hiding this comment.
@lukehutch Please help me check if the method supportsLaunchMode exists. I received this error when trying to build
Error (Xcode): ../../../../.pub-cache/git/flutter-maps-launcher-470dd6965ea83de929851c48723f5745dbafbfcd/lib/maps_launcher.dart:60:13: Error: Method not found: 'supportsLaunchMode'.
There was a problem hiding this comment.
Yes, this method is in url_launcher, which is a dependency of flutter_maps_launcher.
There was a problem hiding this comment.
I did update the deps versions though, as I said in the description, so make sure you update those, then dart pub upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the advice here to try to fix #42.
(The changes are all in maps_launcher.dart, but I also updated the deps, hence the large changeset)