Add timed busy-wait option to pika::barrier wait and arrive_and_wait
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
msimberg
force-pushed
the
barrier-no-yield
branch
from
dfced11
to
83dc22e
Compare
|
bors try |
tryBuild failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to start doing eth-cscs/DLA-Future#833 in DLA-Future. The default behaviour of
waitandarrive_and_waitwith these changes is exactly as before. Both functions now have an optional second parameter to specify a busy-wait time during which the barrier does not yield (thanks to #672). This option should be used with care, but can noticeably improve performance when there are few tasks running outside of those participating in the barrier.