Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase spinlock pool size #1165

Open
msimberg opened this issue Jun 12, 2024 · 0 comments
Open

Increase spinlock pool size #1165

msimberg opened this issue Jun 12, 2024 · 0 comments
Labels
category: CMake category: performance tests effort: 3 A few days of work. priority: low Nice to have, but nobody is going to be sad if this is never done. type: refactoring

Comments

@msimberg
Copy link
Contributor

We currently use a spinlock pool for all thread_data locks. The default size of the pool is 128 locks. With large CPUs like the Grace 72-core CPUs, the default may be a bit cramped. We should consider increasing the default if it doesn't negatively affect smaller core counts. This needs some benchmarks to verify the effect.
@msimberg msimberg added priority: low Nice to have, but nobody is going to be sad if this is never done. and removed priority: medium This should be done sooner or later. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: CMake category: performance tests effort: 3 A few days of work. priority: low Nice to have, but nobody is going to be sad if this is never done. type: refactoring
Projects
pika planning board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msimberg