Fixing Utf8Parser.Number to not modify the value of 'c' (dotnet/corec…

…lr#20967) Commit migrated from dotnet/coreclr@af659af
picenka21 · Nov 13, 2018 · cf760d8 · cf760d8
1 parent 30206f7
commit cf760d8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs b/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs
@@ -84,8 +84,9 @@ private static bool TryParseNumber(ReadOnlySpan<byte> source, ref Number.NumberB
             while (srcIndex != source.Length)
             {
                 c = source[srcIndex];
+                int value = (byte)(c - (byte)('0'));
 
-                if ((c -= (byte)('0')) > 9)
+                if (value > 9)
                 {
                     break;
                 }
@@ -102,7 +103,7 @@ private static bool TryParseNumber(ReadOnlySpan<byte> source, ref Number.NumberB
                     // for an input that falls evenly between two representable
                     // results.
 
-                    hasNonZeroTail |= c;
+                    hasNonZeroTail |= value;
                 }
             }
             number.HasNonZeroTail = (hasNonZeroTail != 0);
@@ -138,8 +139,9 @@ private static bool TryParseNumber(ReadOnlySpan<byte> source, ref Number.NumberB
                 while (srcIndex != source.Length)
                 {
                     c = source[srcIndex];
+                    int value = (byte)(c - (byte)('0'));
 
-                    if ((c -= (byte)('0')) > 9)
+                    if (value > 9)
                     {
                         break;
                     }
@@ -156,7 +158,7 @@ private static bool TryParseNumber(ReadOnlySpan<byte> source, ref Number.NumberB
                         // for an input that falls evenly between two representable
                         // results.
 
-                        hasNonZeroTail |= c;
+                        hasNonZeroTail |= value;
                     }
                 }
                 number.HasNonZeroTail = (hasNonZeroTail != 0);