Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo menu is broken #57

Closed
spruce opened this issue Oct 21, 2015 · 5 comments
Closed

Demo menu is broken #57

spruce opened this issue Oct 21, 2015 · 5 comments

Comments

@spruce
Copy link
Member

spruce commented Oct 21, 2015

Btw. you know that your demo is broken? If you click on a menu element the menu disappears...
Noticed by @wzrdtales

@GCorbel
Copy link
Contributor

GCorbel commented Dec 6, 2015

Hi,

For christmas, I decided to contribute to this project by fixing bugs on the documentation.

I'm trying to serve the dummy app with ember serve. First of all, I had to create an empty Brocfile.js. Now, I want have this message :

Invalid tree found. You must supply a path or an object with a `.read` (deprecated) or `.rebuild` function: Object
Error: Invalid tree found. You must supply a path or an object with a `.read` (deprecated) or `.rebuild` function: Object
    at readAndReturnNodeFor (/app/node_modules/ember-cli/node_modules/broccoli/lib/builder.js:90:13)
    at /app/node_modules/ember-cli/node_modules/broccoli/lib/builder.js:42:14
    at lib$rsvp$$internal$$tryCatch (/app/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (/app/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:505:17)
    at /app/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1001:13
    at lib$rsvp$asap$$flush (/app/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1198:9)
    at doNTCallback0 (node.js:408:9)
    at process._tickCallback (node.js:337:13)

There is a similar issue here : indexiatech/ember-idx-tabs#16.

I think something is deprecated. I will try to fix this issue but let me know if you have the solution.

@GCorbel
Copy link
Contributor

GCorbel commented Dec 6, 2015

I found the solution. I still have problem with css but I will solve it.

@spruce
Copy link
Member Author

spruce commented Dec 6, 2015

I think it is ok, that the Brocfile is not created.
For more info see here: https://github.com/ember-cli/ember-cli/blob/master/TRANSITION.md#brocfile-transition

But thanks for helping out on this project :)

@GCorbel
Copy link
Contributor

GCorbel commented Dec 7, 2015

I forgot to give the link to the PR : #64

@GCorbel
Copy link
Contributor

GCorbel commented Dec 14, 2015

I don't understand but I had a bug last week and add the Brocfile fix it. Now, it works with the master branch.

I will close this issue and rebase my PRs.

@GCorbel GCorbel closed this as completed Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants