PIA-1290: Fix issue where the login screen was presented start on a cold start #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-juan-docal
requested review from
kp-iva-nedeleva and
kp-aldo-pedromingo
as code owners
kp-juan-docal
deleted the
juan.docal/PIA-1290-fix-issue-where-login-screen-was-presented-twice-on-cold-start
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes an issue where the login screen was being presented twice when opening the application while logged out. This is due to the logic updating tokens failing (no known token). This failure is handled as a 401 by the API, which in turn triggers the logic to logout the user, presenting it with the login screen. All that logic is valid, which means I'm just validating that we navigate to the login screen if we are logged in.
Sanity Tests