-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New layout for "All Settings" page #3042
Conversation
db33e79
to
7c823de
Compare
also surround the icons with a SPAN tag. Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
- add class `row` to form-group (because it contains columns) and move the tag to the details function - add class `col-sm-12` to boolean values - add new class `settings-box` to allow targeting only settings boxes Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
- change label style and width - set icons padding Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
This replaces the original `<select>` and merges the options with the "allowed values" block in a single one, simplifying the presentation. Also, the defaultValueHint was incorporated into the default value. Signed-off-by: RD WebDesign <[email protected]>
- Adjust styles to show only one column in mid and small screens - also group all "settings" styles Signed-off-by: RD WebDesign <[email protected]>
- remove the external green boxes; - remove border from inner boxes (and change the box-shadow); - add navigation and tabs for settings sections; - adjust/add some classes for formatting Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
and fix the navigation basic style colors Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
7c823de
to
5db10ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this change. It looks much nicer with the tabs. But as a user I wouldn't know if I need to save after changing settings in one tab or if I could do changes on multiple tabs and only save once. Any idea how to let the user know?
Overall, I like this change - it looks really smart. One possible change request, however... Could we make it more obvious that the tab headers are, in fact, tab headers? Took me a moment to notice that they were there as the background colour of the buttons is the same as the page background - doesn't visually stick out as a tabbed layout (to my eye!) |
One small drawback with tabs is that you can't search across all settings right away eg. directly jump to a certain debug setting. |
Ah yes, I suppose currently you can load the page and I wonder, as the data is technically still on the page (just hidden with some CSS?) Is there some super magic js/css that can be employed here to make the tab get selected and shown based on the contents of the |
Well... with tabs there will be less visible content on each tab, making it easier to visually search, but slightly more difficult to search using
Not possible, because |
Sorry - having "ideas" again... When toggling to modified settings only, could we either: Might save a few clicks when looking for modified settings
I figured that would be the case. What about a custom search box at the top of the all settings page, above the tabs/next to the toggle switch |
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
6303c2d
to
20fc994
Compare
What does this PR accomplishes?
This PR creates a cleaner layout for All Settings page, removing a few boxes and borders.
It also improves the number of columns, depending on the screen size (1 column in small and medium screens, 2 columns in large screens and 3 columns in very large screens).
By submitting this pull request, I confirm the following:
git rebase
)