Fix multi-deletion of DHCP leases

[DL6ER]

What does this implement/fix?

IP lease deletion incorrectly utilized parseInt(..., 10) which truncated, e.g., 127.0.0.1 to 127 which was then sent to the API. This PR also adds a further improvement to toast handling where an existing toast can be memorized by the caller to update exactly this one single toast later on with either success or error. This is only relevant for mass-events and can later trivially be extended to other places where this is meaningful.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

Checklist:

• The code change is tested and works locally.
• I based my code and PRs against the repositories developmental branch.
• I signed off all commits. Pi-hole enforces the DCO for all contributions
• I signed all my commits. Pi-hole requires signatures to verify authorship
• I have read the above and my PR is ready for review.

[DL6ER]

Rebased on latest development-v6 and ported missing changes from the recently closed #3034

[rdwebdesign]

The ID is returned on error. I think we could also show the ID on success.

Suggested change

	"Successfully deleted message",
	"Successfully deleted message ID: " + id,

Without the ID, if you delete 5 messages there will be 5 toasts with the exactly same text.

[DL6ER]

Two comments: If we use your suggestion, I'd suggest an additional space between : and ". Otherwise, how about putting the ID into the second line (currently null to be disabled)? This is also where we are putting domains/regex, etc. in other toasts.

[rdwebdesign]

I'm OK with both solutions:

• space after "ID:" (suggestion updated) or
• replacing the null parameter with ID: XX.

I just don't want to remove the string "ID:" to avoid confusion between the ID and the count of deleted items.

[rdwebdesign]

As you said, a second option would be to change the title and also replace the empty message with something like this:

Suggested change

	"Successfully deleted message",
	"",
	"Success",
	"Message ID: " + id + " deleted.",

Wrong button