Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat empty string in pipeline_error as success #1525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treat empty string in pipeline_error as success #1525

wants to merge 1 commit into from
+1 −1

Conversation

kylewillmon
Copy link
Contributor

Closes #1524

@kylewillmon kylewillmon requested a review from a team as a code owner October 22, 2024 13:59
maxrake
maxrake requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG entry needed. Otherwise, LGTM.

Confirmed with local checkout and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake requested changes

@mathew-horner mathew-horner Awaiting requested review from mathew-horner mathew-horner is a code owner automatically assigned from phylum-dev/user-components

Requested changes must be addressed to merge this pull request.

Assignees

@kylewillmon kylewillmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI returns error while API returns success
2 participants
@kylewillmon @maxrake