Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed failure modes #36

Open
sonOfRa opened this issue Jan 24, 2018 · 3 comments
Open

More detailed failure modes #36

sonOfRa opened this issue Jan 24, 2018 · 3 comments

Comments

@sonOfRa
Copy link

sonOfRa commented Jan 24, 2018

When verifying the password in argon2-jvm, it can only return true or false. The native verify-function however also passes through other error codes, like ARGON2_DECODING_FAIL or ARGON2_INCORRECT_TYPE if the hash is ill-formed. Is there any chance of exposing this information (for example via exceptions) in argon2-jvm?

@phxql
Copy link
Owner

phxql commented Jan 24, 2018

I could add a more advanced verify method in the Argon2Advanced interface. Do you need that or is that only a nice-to-have feature?

@phxql phxql self-assigned this Jan 24, 2018
@sonOfRa
Copy link
Author

sonOfRa commented Jan 24, 2018

Nice-to-have. I'm building a password-hashing library at https://github.com/sonOfRa/pwhash, and was considering exposing more than success/failure. But I'm not even sure if I'll do that or just stick with "false" on every failure mode. So definitely a rather low-priority feature.

@phxql
Copy link
Owner

phxql commented Jan 25, 2018

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants