Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let runfiles env vars take priority #2

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Let runfiles env vars take priority #2

merged 1 commit into from
Jan 17, 2022

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 30, 2021

@phst
Copy link
Owner

phst commented Dec 30, 2021

I agree that this is the better choice, but I think we should try to fix https://docs.google.com/document/d/e/2PACX-1vSDIrFnFvEYhKsCMdGdD40wZRBX3m3aZ5HhVj4CtHPmiXKDCxioTUbYsDydjKtFDAzER5eg7OjJWs3V/pub first.
As an alternative, callers can pass an invalid program name using e.g. ProgramName("/invalid"); that's a bit of a hack, but should reliably suppress the unwanted behavior.

phst
phst reviewed Jan 17, 2022
View reviewed changes
runfiles.go Outdated Show resolved Hide resolved
@phst phst merged commit f6dd635 into phst:master Jan 17, 2022
phst added a commit that referenced this pull request Jan 17, 2022
@phst
Don’t inject an invalid program name and directory in unit test.
f8065aa 
After #2, the manifest file always takes
precedence, so this is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phst phst phst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifest-based runfiles lookup is non-hermetic
2 participants
@fmeum @phst