FP assuming method purity even after state change in bleeding edge

[dktapps]

Bug report

This only happens when bleedingEdge is used.

Code snippet that reproduces the problem

https://phpstan.org/r/7630b305-3559-42e6-b125-a876bcce437e
https://phpstan.org/r/8f63b716-d2b7-4dca-b41f-98659f991e35

Expected output

Both samples should be error-free, because $this->damage is modified directly before the isBroken() call, which may cause a different result to be returned.

[phpstan-bot]

@dktapps After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+25: If condition is always false.

Full report

Line	Error
25	If condition is always false.

[dktapps]

now both samples have the bogus error..??

[ondrejmirtes]

If you check out today's commits in master, you'll understand why.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@5f91da6

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.