False positive with \Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface::get()

[alexsakhnov]

Symfony ContainerBagInterface implements Psr\Container\ContainerInterface but actually it returns a container parameter, not a service.

However ContainerInterfaceUnknownServiceRule checks for service existence, not parameter. For example this code

/** @var \Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface $params */
$parameterValue = $params->get('parameter_name');

results in the following error

Service "parameter_name" is not registered in the container.

I suggest to ignore subtypes of ContainerBagInterface in the ContainerInterfaceUnknownServiceRule. Is this correct?

[ondrejmirtes]

Hi, this is easy to fix. See the instructions: https://phpstan.org/developing-extensions/type-system#querying-a-specific-type

Just adding an if with (new ObjectType(ContainerInterface::class))->isSuperTypeOf($argType)->yes() should be fine. There are already some exceptions there:

phpstan-symfony/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php

Lines 62 to 69 in fe5f5d8

	if (
	!$isControllerType->yes()
	&& !$isAbstractControllerType->yes()
	&& !$isContainerType->yes()
	&& !$isPsrContainerType->yes()
	) {
	return [];
	}

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.