Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getimagesize: zero is a possible value for height and width #3207

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix getimagesize: zero is a possible value for height and width #3207

merged 1 commit into from
Jul 2, 2024

Conversation

mfruehauf
Copy link

https://phpstan.org/r/f0ef9a4e-00d2-4df9-a129-a79857f28273

See documentation:

Some formats may contain no image or may contain multiple images. In these cases, getimagesize() might not be able to properly determine the image size. getimagesize() will return zero for width and height in these cases.

@mfruehauf mfruehauf mentioned this pull request Jul 2, 2024
Merged
staabm
staabm reviewed Jul 2, 2024
View reviewed changes
resources/functionMap.php Outdated Show resolved Hide resolved
staabm
staabm approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thank you

@ondrejmirtes ondrejmirtes merged commit 123e2ac into phpstan:1.11.x Jul 2, 2024
450 of 454 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@mfruehauf mfruehauf deleted the fixGetimagesize branch July 4, 2024 07:12
MidnightDesign added a commit to MidnightDesign/psalm that referenced this pull request Jul 11, 2024
@MidnightDesign
Width and height might be 0
f3c640a 
See phpstan/phpstan-src#3207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfruehauf @ondrejmirtes @staabm