Fix typo in ObjectType #3206
Merged
Fix typo in ObjectType #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 2, 2024
staabm
commented
Jul 2, 2024
| @@ -1230,15 +1230,15 @@ public function getEnumCases(): array | |||
| $className = $classReflection->getName(); | |||
|
|
|||
| if ($this->subtractedType !== null) { | |||
| $subtracedEnumCaseNames = []; | |||
| $subtractedEnumCaseNames = []; | |||
staabm
commented
Jul 2, 2024
| @@ -1384,7 +1386,7 @@ public function changeSubtractedType(?Type $subtractedType): Type | |||
| $subtractedTypesList = TypeUtils::flattenTypes($subtractedType); | |||
| $subtractedTypes = []; | |||
| foreach ($subtractedTypesList as $type) { | |||
| $subtractedTypes[$type->describe(VerbosityLevel::precise())] = $type; | |||
There was a problem hiding this comment.
I think we don't need the key of this array and building up the descriptions shows up in profiles of phpstan/phpstan#11263
There was a problem hiding this comment.
after getting rid of the key, it seems we can get rid of the whole loop
|
intially started as a typo fix, but after some closer looks I was able to remove some unnecessary code repro of phpstan/phpstan#11263 before this PR: after |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.