RegexArrayShapeMatcher - Narrow types in alternation of top level capturing groups #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jul 1, 2024
src/Type/Php/RegexCapturingGroup.php
Outdated
| private bool $inOptionalQuantification, | ||
| private RegexCapturingGroup|RegexNonCapturingGroup|null $parent, | ||
| ) | ||
| { | ||
| $this->id = self::$idGenerator; | ||
| self::$idGenerator++; |
There was a problem hiding this comment.
I don't like global state like that. This should be passed as a plain number from the outside and counted in the instance that creates objects of this class.
| } | ||
| assertType('array{0: string, 1: string, 2: string, 3?: string, 4?: string}', $matches); | ||
|
|
||
| if (preg_match('~^(?:(\\d+)x(\\d+)|(\\d+)|x(\\d+))?$~', $size, $matches) !== 1) { |
There was a problem hiding this comment.
Better to divide this in multiple functions, reusing the $matches variable like that seems dirty to me.
|
feedback addressed - thank you |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the 2 repros of phpstan/phpstan#11221 (comment)