TypeCombinator: Don't combine array-shapes of lists with non-lists #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change makes sense as is in isolation. maybe it does not yet address all the problems I need to solve for the case at hand and needs another fix after I can combine it with the open |
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jul 1, 2024
| @@ -1532,6 +1532,10 @@ public function isKeysSupersetOf(self $otherArray): bool | |||
| return $keyTypesCount === 0; | |||
| } | |||
|
|
|||
| if (!$this->isList->equals($otherArray->isList)) { | |||
There was a problem hiding this comment.
I'd rather have this line of code say:
if ($this->isList->yes() !== $otherArray->isList->yes()) {But I can't explain why, feel better to me. I'm going to let you come up with test cases that will have different results because of this change :)
|
The initial motivation of this PR was fixed differently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idea is to not combine lists with non-lists array-shapes. keeping them separate yields a more precise union which later on can lead to better analysis results
motivated by the issue described in phpstan/phpstan#11256 (reply in thread)