Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using AlwaysRememberedExpr when match expression condition is a BinaryOperation #3195

Closed
wants to merge 1 commit into from
Closed

Avoid using AlwaysRememberedExpr when match expression condition is a BinaryOperation #3195

wants to merge 1 commit into from

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Jun 28, 2024 •
edited
Loading

@jdecool jdecool changed the title Avoid using AlwaysRememberedExpr when process match expression Avoid using AlwaysRememberedExpr when match expression condition is a BinaryOperation Jun 28, 2024
@ondrejmirtes
Copy link
Member

I'm sorry, but I fell like this isn't the right solution. But I haven't found the right one yet. I thought that we need to unset AlwaysRememberedExpr in generalizeVariableTypeHolders and maybe also mergeVariableHolders but it didn't work for me.

@ondrejmirtes
Copy link
Member

This was the right fix: 0799527

Thank for the test.

@jdecool jdecool deleted the fix-bug-11246 branch June 30, 2024 18:31
@jdecool
Copy link
Contributor Author

jdecool commented Jun 30, 2024

Thanks @ondrejmirtes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculations seems to be not correctly interpreted from match
2 participants
@jdecool @ondrejmirtes