Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v)sprintf() can return false on PHP7 #3193

Closed
wants to merge 6 commits into from
Closed

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 28, 2024

we are missing sprintf/vsprintf can return false on php7

https://3v4l.org/aEqBC

@staabm
Copy link
Contributor Author

staabm commented Jun 28, 2024

hmm I wonder how annoying this change is in practice, as can be seen already at the phpstan own codebase (example), that this triggers lots of warnings.

@ondrejmirtes wdyt about turning this into a benevolent (string|false) on php7?

@ondrejmirtes
Copy link
Member

The fact that there's no bug report for this means that this false rarely happens in practice and gets rarely handled which means I don't want to add it to the return type on PHP 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants