From e2978a31105ab20b3892bdf7a2a55defbc1c4a56 Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Tue, 2 Jan 2024 21:23:41 +0100
Subject: [PATCH] Artifact actions v4

---
 .github/workflows/apiref.yml                 |  4 ++--
 .github/workflows/issue-bot.yml              | 19 ++++++++++---------
 .github/workflows/phar.yml                   |  6 +++---
 .github/workflows/reflection-golden-test.yml |  6 +++---
 .github/workflows/static-analysis.yml        |  4 ++--
 5 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/apiref.yml b/.github/workflows/apiref.yml
index c782bcc400..8d9f8b97f8 100644
--- a/.github/workflows/apiref.yml
+++ b/.github/workflows/apiref.yml
@@ -45,7 +45,7 @@ jobs:
         run: "apigen/vendor/bin/apigen -c apigen/apigen.neon --output docs -- src vendor/nikic/php-parser vendor/ondrejmirtes/better-reflection vendor/phpstan/phpdoc-parser"
 
       - name: "Upload docs"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: docs
           path: docs
@@ -63,7 +63,7 @@ jobs:
           node-version: "16"
 
       - name: "Download docs"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: docs
           path: docs
diff --git a/.github/workflows/issue-bot.yml b/.github/workflows/issue-bot.yml
index 7cf17c8a29..32240134a8 100644
--- a/.github/workflows/issue-bot.yml
+++ b/.github/workflows/issue-bot.yml
@@ -63,12 +63,12 @@ jobs:
         run: echo "matrix=$(./console.php download)" >> $GITHUB_OUTPUT
 
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: playground-cache
           path: issue-bot/tmp/playgroundCache.tmp
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: issue-cache
           path: issue-bot/tmp/issueCache.tmp
@@ -100,7 +100,7 @@ jobs:
         working-directory: "issue-bot"
         run: "composer install --no-interaction --no-progress"
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: playground-cache
           path: issue-bot/tmp
@@ -110,9 +110,9 @@ jobs:
         timeout-minutes: 5
         run: ./console.php run ${{ matrix.phpVersion }} ${{ matrix.playgroundExamples }}
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
-          name: results
+          name: results-${{ matrix.phpVersion }}
           path: issue-bot/tmp/results-${{ matrix.phpVersion }}-*.tmp
 
   evaluate:
@@ -135,19 +135,20 @@ jobs:
         working-directory: "issue-bot"
         run: "composer install --no-interaction --no-progress"
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: playground-cache
           path: issue-bot/tmp
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: issue-cache
           path: issue-bot/tmp
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: results
+          pattern: results-*
+          merge-multiple: true
           path: issue-bot/tmp
 
       - name: "Evaluate results - pull request"
diff --git a/.github/workflows/phar.yml b/.github/workflows/phar.yml
index 3644380af8..ef0f975e49 100644
--- a/.github/workflows/phar.yml
+++ b/.github/workflows/phar.yml
@@ -59,7 +59,7 @@ jobs:
         working-directory: "compiler/build"
         run: "php box.phar compile --no-parallel"
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: phar-file
           path: tmp/phpstan.phar
@@ -96,7 +96,7 @@ jobs:
         id: "checksum"
         run: echo "md5=$(md5sum tmp/phpstan.phar | cut -d' ' -f1)" >> $GITHUB_OUTPUT
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: phar-file-checksum
           path: tmp/phpstan.phar
@@ -190,7 +190,7 @@ jobs:
           fi
 
       - name: "Download phpstan.phar"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: phar-file
 
diff --git a/.github/workflows/reflection-golden-test.yml b/.github/workflows/reflection-golden-test.yml
index 5be71ab360..3534e0a92b 100644
--- a/.github/workflows/reflection-golden-test.yml
+++ b/.github/workflows/reflection-golden-test.yml
@@ -50,7 +50,7 @@ jobs:
       - name: "Dump phpSymbols.txt"
         run: "php tests/dump-reflection-test-symbols.php"
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: phpSymbols
           path: ${{ env.REFLECTION_GOLDEN_SYMBOLS_FILE }}
@@ -74,7 +74,7 @@ jobs:
 
     steps:
       - name: "Download phpSymbols.txt"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: phpSymbols
           path: /tmp
@@ -105,7 +105,7 @@ jobs:
       - name: "Dump previous reflection data"
         run: "php tests/generate-reflection-test.php"
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: reflection-${{ matrix.php-version }}.test
           path: ${{ env.REFLECTION_GOLDEN_TEST_FILE }}
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
index 01ebc16c7d..a3880848cd 100644
--- a/.github/workflows/static-analysis.yml
+++ b/.github/workflows/static-analysis.yml
@@ -62,7 +62,7 @@ jobs:
 
       - name: "Upload transformed sources"
         if: matrix.php-version == '7.2'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: transformed-src
           path: src
@@ -126,7 +126,7 @@ jobs:
           make phpstan-result-cache
 
       - name: "Upload result cache artifact"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: resultCache-ubuntu-latest.php
           path: tmp/resultCache.php