From 815270d8933b9cdefa4613f0baf17bcbff91be6f Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Wed, 3 Jul 2024 17:39:27 +0200
Subject: [PATCH] Observe `@no-named-arguments` above class

---
 src/Analyser/NodeScopeResolver.php            |  3 ++
 src/Reflection/ClassReflection.php            | 12 +++++
 .../TypesAssignedToPropertiesRuleTest.php     | 16 ++++++
 .../Rules/Properties/data/bug-11275.php       | 52 +++++++++++++++++++
 4 files changed, 83 insertions(+)
 create mode 100644 tests/PHPStan/Rules/Properties/data/bug-11275.php

diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
index 9ae174f46..bbc886a41 100644
--- a/src/Analyser/NodeScopeResolver.php
+++ b/src/Analyser/NodeScopeResolver.php
@@ -6005,6 +6005,9 @@ public function getPhpDocs(Scope $scope, Node\FunctionLike|Node\Stmt\Property $n
 			$isPure = $resolvedPhpDoc->isPure();
 			$isAllowedPrivateMutation = $resolvedPhpDoc->isAllowedPrivateMutation();
 			$acceptsNamedArguments = $resolvedPhpDoc->acceptsNamedArguments();
+			if ($acceptsNamedArguments && $scope->isInClass()) {
+				$acceptsNamedArguments = $scope->getClassReflection()->acceptsNamedArguments();
+			}
 			$isReadOnly = $isReadOnly || $resolvedPhpDoc->isReadOnly();
 			$asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
 			$selfOutType = $resolvedPhpDoc->getSelfOutTag() !== null ? $resolvedPhpDoc->getSelfOutTag()->getType() : null;
diff --git a/src/Reflection/ClassReflection.php b/src/Reflection/ClassReflection.php
index 8106faf39..7c9a569dc 100644
--- a/src/Reflection/ClassReflection.php
+++ b/src/Reflection/ClassReflection.php
@@ -102,6 +102,8 @@ class ClassReflection
 
 	private ?bool $hasConsistentConstructor = null;
 
+	private ?bool $acceptsNamedArguments = null;
+
 	private ?TemplateTypeMap $templateTypeMap = null;
 
 	private ?TemplateTypeMap $activeTemplateTypeMap = null;
@@ -1243,6 +1245,16 @@ public function hasConsistentConstructor(): bool
 		return $this->hasConsistentConstructor;
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		if ($this->acceptsNamedArguments === null) {
+			$resolvedPhpDoc = $this->getResolvedPhpDoc();
+			$this->acceptsNamedArguments = $resolvedPhpDoc === null || $resolvedPhpDoc->acceptsNamedArguments();
+		}
+
+		return $this->acceptsNamedArguments;
+	}
+
 	public function isFinalByKeyword(): bool
 	{
 		if ($this->isAnonymous()) {
diff --git a/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php b/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
index 9c14a0571..719d61044 100644
--- a/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
+++ b/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
@@ -614,4 +614,20 @@ public function testGenericsInCallableInConstructor(): void
 		$this->analyse([__DIR__ . '/data/generics-in-callable-in-constructor.php'], []);
 	}
 
+	public function testBug11275(): void
+	{
+		if (PHP_VERSION_ID < 70400) {
+			$this->markTestSkipped('Test requires PHP 7.4.');
+		}
+
+		$this->checkExplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-11275.php'], [
+			[
+				'Property Bug11275\D::$b (list<Bug11275\B>) does not accept array<int|string, Bug11275\B>.',
+				50,
+				'array<int|string, Bug11275\B> might not be a list.',
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Properties/data/bug-11275.php b/tests/PHPStan/Rules/Properties/data/bug-11275.php
new file mode 100644
index 000000000..cf54868d0
--- /dev/null
+++ b/tests/PHPStan/Rules/Properties/data/bug-11275.php
@@ -0,0 +1,52 @@
+<?php // lint >= 7.4
+
+namespace Bug11275;
+
+/**
+ * @no-named-arguments
+ */
+final class A
+{
+	/**
+	 * @var list<B>
+	 */
+	private array $b;
+
+	public function __construct(B ...$b)
+	{
+		$this->b = $b;
+	}
+}
+
+final class B
+{
+}
+
+final class C
+{
+	/**
+	 * @var list<B>
+	 */
+	private array $b;
+
+	/**
+	 * @no-named-arguments
+	 */
+	public function __construct(B ...$b)
+	{
+		$this->b = $b;
+	}
+}
+
+final class D
+{
+	/**
+	 * @var list<B>
+	 */
+	private array $b;
+
+	public function __construct(B ...$b)
+	{
+		$this->b = $b;
+	}
+}