Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AbstractQuery::getSingleScalarResult #611

Open
ruudk opened this issue Sep 17, 2024 · 1 comment
Open

Support AbstractQuery::getSingleScalarResult #611

ruudk opened this issue Sep 17, 2024 · 1 comment

Comments

@ruudk
Copy link
Contributor

ruudk commented Sep 17, 2024

It appears that getSingleScalarResult() currently always returns bool|float|int|string|null.

If I have the following query:

$result = $this->createQueryBuilder('u')
            ->select('COUNT(u.id)')
            ->where('u.is_deleted = false')
            ->getQuery()
            ->getSingleScalarResult();

\PHPStan\assertType($result, 'bool|float|int|string|null');

But when I do getResult() it works properly:

$result = $this->createQueryBuilder('u')
            ->select('COUNT(u.id)')
            ->where('u.is_deleted = false')
            ->getQuery()
            ->getSingleScalarResult();

\PHPStan\assertType($result, 'list<array{1: int<0, max>}>');

I wonder why we cannot support getSingleScalarResult? I created the following helper:

/**
 * @template TValue of scalar
 * @param list<array{1: TValue}> $results
 *
 * @return TValue
 */
protected function getSingleScalarResult(array $results) : bool | float | int | string
{
    return $results[0][array_key_first($results[0])];
}

And now this works great:

$result = $this->getSingleScalarResult($this->createQueryBuilder('u')
            ->select('COUNT(u.id)')
            ->where('u.is_deleted = false')
            ->getQuery()
            ->getResult());

\PHPStan\assertType($result, 'int<0, max>');

Am I being naive here and is there a flaw with my solution or would it be possible to support it 😁?

/cc @arnaud-lb @janedbal

References:

@VincentLanglet
Copy link
Contributor

Not as easy as it looks.

See

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants