Query loses its result type when using setLockMode or setHint

[noemi-salaun]

When using setLockMode() or setHint() on a Query, PHPStan stop inferring the result type.

GOOD TYPE

$user = $entityManager
    ->getRepository(User::class)
    ->createQueryBuilder('user')
    ->where('user.id = :userId')
    ->getQuery()
    ->getResult();

\PHPStan\dumpType($user); // -> Dumped type: array<App\User>

MIXED TYPE

$user = $entityManager
    ->getRepository(User::class)
    ->createQueryBuilder('user')
    ->where('user.id = :userId')
    ->getQuery()
    ->setLockMode(LockMode::PESSIMISTIC_READ) // <- Add this line
    ->getResult();

\PHPStan\dumpType($user); // -> Dumped type: mixed

[VincentLanglet]

Hi @noemi-salaun, this can be fixed directly on doctrine/orm.

The return type is self but the phpdoc should be more precise.
https://github.com/doctrine/orm/blob/2.13.x/lib/Doctrine/ORM/Query.php#L775
Adding /** @return $this */ will solve the issue.

I opened the PR doctrine/orm#10238

[VincentLanglet]

This will be fixed in 2.14 version of doctrine

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.