fix: should not fail on long body when using git --verbose #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oallain
reviewed
Jan 6, 2020
src/Task/Git/CommitMessage.php
Outdated
| @@ -294,9 +294,14 @@ private function subjectIsSingleLined(ContextInterface $context): bool | |||
| private function getCommitMessageLinesWithoutComments(string $commitMessage): array | |||
| { | |||
| $lines = preg_split('/\R/u', $commitMessage); | |||
| $everything_below_will_be_ignored = false; | |||
There was a problem hiding this comment.
Sure, committed the style change f732427
oallain
approved these changes
Jan 7, 2020
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit looks for a known marker in the git commit message when using
git --verbosewhen the marker is seen it will ignore all lines after that (it will assume them to be comments).The specs will test that long commit messages still fails above the marker.
New Task Checklist:
run()method readable?run()method using the configuration correctly?