Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PSR12 to documentation #691

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Adding PSR12 to documentation #691

merged 1 commit into from
Nov 28, 2019

Conversation

ChrisB9
Copy link
Contributor

@ChrisB9 ChrisB9 commented Oct 24, 2019

Since PHP-CS-Fixer/PHP-CS-Fixer#4502 will soon be merged, the documentation should mention this change too in the future

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets -

This PR just completes the list of supported standards for phpcs

Since PHP-CS-Fixer/PHP-CS-Fixer#4502 has been merged and is now supported, the documentation should mention this too
@Landerstraeten Landerstraeten added this to the 0.16.2 milestone Oct 25, 2019
@veewee veewee removed this from the 0.16.2 milestone Oct 29, 2019
@veewee
Copy link
Contributor

veewee commented Oct 29, 2019

Thanks @ChrisB9. Can you give us a ping once it is officially available?

@ChrisB9
Copy link
Contributor Author

ChrisB9 commented Oct 29, 2019

@veewee absolutely, i'm having an eye on it

@drupol
Copy link
Contributor

drupol commented Nov 27, 2019

It's available and this can be merged.

@veewee
Copy link
Contributor

veewee commented Nov 28, 2019

Thanks for the notification!

@veewee veewee merged commit 9fc00eb into phpro:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants