Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Phpcs exclude option #634

Merged
merged 6 commits into from
May 16, 2019
Merged

Conversation

JTubex
Copy link
Contributor

@JTubex JTubex commented May 15, 2019

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes

Add the exclude option to the phpcs-task: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#limiting-results-to-specific-sniffs

@JTubex JTubex changed the title Phpcs exclude Implement the Phpcs exclude option May 15, 2019
Copy link
Contributor

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update spec/Task/PhpcsSpec.php by add

$options->getDefinedOptions()->shouldContain('exclude');

after this line https://github.com/phpro/grumphp/blob/master/spec/Task/PhpcsSpec.php#L54

@JTubex
Copy link
Contributor Author

JTubex commented May 15, 2019

Hmm, tests are failing because of the following error:
1) GrumPHPTest\E2E\FolderStructuresTest::it_has_all_config_files_in_root_git_dir 320Symfony\Component\Process\Exception\ProcessTimedOutException: The process "c:\tools\php71\php.EXE C:\tools\composer install --optimize-autoloader --no-interaction" exceeded the timeout of 60 seconds.

@veewee veewee added this to the 0.15.1 milestone May 16, 2019
@veewee
Copy link
Contributor

veewee commented May 16, 2019

Looks good, thanks for the PR!

@oallain
Copy link
Contributor

oallain commented May 16, 2019

Good job !

@JTubex
Copy link
Contributor Author

JTubex commented May 16, 2019

Thanks, guys!

@Landerstraeten Landerstraeten merged commit d90d5a2 into phpro:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants