-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Phpcs exclude option #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update spec/Task/PhpcsSpec.php by add
$options->getDefinedOptions()->shouldContain('exclude');
after this line https://github.com/phpro/grumphp/blob/master/spec/Task/PhpcsSpec.php#L54
Hmm, tests are failing because of the following error: |
Looks good, thanks for the PR! |
Good job ! |
Thanks, guys! |
Add the exclude option to the phpcs-task: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#limiting-results-to-specific-sniffs