Improve level parameter of PhpStan task
#612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Mar 24, 2019
|
Thanks for the PR, I've added a small remark. |
| * @param string $argument | ||
| * @param mixed $value | ||
| */ | ||
| public function addOptionalMixedArgument(string $argument, $value) |
There was a problem hiding this comment.
@veewee I think there is no need to add this new function? Can't we just use addOptionalArgument()?
There was a problem hiding this comment.
No it can't.
The addOptionalArgument() method does not add the argument on e.g. value 0.
In this case 0 is a valid value, so we have to use a null check to make sure it falls back to the phsptan configuration file or phpstan default value instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the two new values
NULLand"max"for thelevelparameter of the PhpStan task.NULLwill omit the--levelcommand line option, which is useful for projects with a phpstan.neon config file.