Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed class name duplicated into comments and package annotations. #269

Merged
merged 2 commits into from
Jan 16, 2017

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Jan 14, 2017

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets n/a

Class names duplicated into class docblocks and namespaces duplicated in @package annotations are pure technical debt, providing no added value but producing maintenance burden to ensure they remain correct.

I presume nobody manually entered these comments so you probably want to look into reconfiguring your editor templates to prevent perpetuating this problem.

@veewee
Copy link
Contributor

veewee commented Jan 16, 2017

Thanks for the PR! I agree that it is unmaintainable technical debt. Let's get rid of it :)

@veewee veewee added this to the Version 0.11.2 milestone Jan 16, 2017
@veewee veewee merged commit adee1a6 into phpro:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants