Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1126 bin console task sf #1138

Merged
merged 11 commits into from
Jun 14, 2024
Merged

1126 bin console task sf #1138

merged 11 commits into from
Jun 14, 2024

Conversation

bortefi
Copy link
Contributor

@bortefi bortefi commented May 31, 2024

Q A
Branch v2.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #1126

Added Task: Symfony Console: execute symfony command

  • 🚫 php executable finder
  • configurable bin path, defaults to project root ./bin/console

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green? ⚠️ awaiting github ci runner

Future Improvements (not included)

  • 🚫 symfony/flex recipe for console component could be required to generate bin/console if not existing on the project

Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I've listed a couple of possible improvements.

src/Task/SymfonyConsole.php Show resolved Hide resolved
src/Task/SymfonyConsole.php Outdated Show resolved Hide resolved
doc/tasks/symfony_console.md Show resolved Hide resolved
doc/tasks/symfony_console.md Show resolved Hide resolved
src/Task/SymfonyConsole.php Outdated Show resolved Hide resolved
src/Task/SymfonyConsole.php Outdated Show resolved Hide resolved
doc/tasks/symfony_console.md Outdated Show resolved Hide resolved
src/Task/SymfonyConsole.php Show resolved Hide resolved
@veewee veewee merged commit 96604b0 into phpro:v2.x Jun 14, 2024
20 checks passed
@bortefi bortefi deleted the 1126-bin-console-task-sf branch June 14, 2024 12:46
@veewee veewee added this to the 2.6.0 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants