Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradually upgrade to PHP 7.0 #482

Closed
5 tasks
veewee opened this issue Mar 30, 2018 · 5 comments
Closed
5 tasks

Gradually upgrade to PHP 7.0 #482

veewee opened this issue Mar 30, 2018 · 5 comments

Comments

@veewee
Copy link
Contributor

veewee commented Mar 30, 2018

Follow up issue of #434.

These steps should be done in separate - easy to review - PRs.

  • Inject strict parameters in functions
  • Inject strict return types in functions
  • Remove unnecesary docblocks
  • Declare strict types
  • Upgrade configuration
@Landerstraeten
Copy link
Contributor

7.0 or 7.1 ?

@veewee
Copy link
Contributor Author

veewee commented Apr 3, 2018

Lets start with adopting the new 7.0 options. ;)

@veewee
Copy link
Contributor Author

veewee commented Aug 31, 2018

@Landerstraeten Any updates on this? Does the grumpy-seventies branch works for you?

@richardhughes
Copy link
Contributor

Hey @veewee, How is this progressing? If you need a hand, I'll be happy to help

@veewee
Copy link
Contributor Author

veewee commented Oct 4, 2018

Hi @richardhughes,

The gurmpy-seventies branch is existing for a while now. You can use that one and create pull requests against that branch if you find any issues. I am planning to do a test session with @Landerstraeten at the end of the month and merge it in once it works good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants