Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does GrumPHP support automatic fixing? #259

Closed
Bilge opened this issue Jan 11, 2017 · 5 comments
Closed

Does GrumPHP support automatic fixing? #259

Bilge opened this issue Jan 11, 2017 · 5 comments
Labels

Comments

@Bilge
Copy link
Contributor

Bilge commented Jan 11, 2017

Q A
Question? yes

The animated introduction shows that, "PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY". I understand this is a message from phpcs and not GrumPHP directly, but does GrumPHP have support for fixing violations directly or can it only notify about problems?

@Kanti
Copy link
Contributor

Kanti commented Jan 11, 2017

GrumPHP dose not autofix things for you.
more Information for this decision: #110

@Bilge
Copy link
Contributor Author

Bilge commented Jan 11, 2017

@Kanti Thank you. I suggest information gleaned from my recent round of questions be added to the documentation to make key decisions like this clear to all users.

@veewee
Copy link
Contributor

veewee commented Jan 12, 2017

the feedback on this issue will be added to the documentation. In the meantime, I created #265 to keep track on this change. I'll close this issue for now.

@Mte90
Copy link

Mte90 commented Sep 4, 2017

The copy and paste of the command is very uncomfortable because eveyr parameter and command is wrapped inside ' so I have to clean manually.
Maybe a command like -fix can be helpful if run the phpcbf automatically.

@Bilge
Copy link
Contributor Author

Bilge commented Sep 4, 2017

Every parameter is supposed to be quoted. You don't have to "clean" anything. Also your comment has nothing to do with this (closed) issue so kindly refrain from further comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants