Merge pull request #886 from AegirLeet/fix-composer-task

Fix composer task when packagist.org is disabled
phpro · Apr 28, 2021 · f476085 · f476085
2 parents 5820a5a + 06aa399
commit f476085
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Task/Composer.php b/src/Task/Composer.php
@@ -105,7 +105,7 @@ private function hasLocalRepository(SplFileInfo $composerFile): bool
         }
 
         foreach ($package['repositories'] as $repository) {
-            if ('path' === $repository['type']) {
+            if ('path' === ($repository['type'] ?? null)) {
                 return true;
             }
         }

diff --git a/test/Unit/Task/ComposerTest.php b/test/Unit/Task/ComposerTest.php
@@ -152,6 +152,22 @@ function () {
                 );
             }
         ];
+        yield 'packagistDotOrgDisabled' => [
+            [
+                'no_local_repository' => true,
+            ],
+            $this->mockContext(RunContext::class, ['composer.json']),
+            function () {
+                $this->mockProcessBuilder('composer', $this->mockProcess(0));
+                $this->filesystem->readFromFileInfo(Argument::which('getBasename', 'composer.json'))->willReturn(
+                    json_encode([
+                        'repositories' => [
+                            ['packagist.org' => false],
+                        ],
+                    ])
+                );
+            }
+        ];
     }
 
     public function provideSkipsOnStuff(): iterable