Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 compatibility - Implement Nullable types #31

Closed
asgrim opened this issue Apr 17, 2017 · 2 comments
Closed

PHP 7.1 compatibility - Implement Nullable types #31

asgrim opened this issue Apr 17, 2017 · 2 comments

Comments

@asgrim
Copy link
Contributor

asgrim commented Apr 17, 2017

I'd like to patch TypeResolver to handle nullable types. Would you prefer a Nullable type with actual type as child, or would you prefer a "flag" to be added to all the types? I think the former is cleaner (and echos how the AST is structured in PhpParser) but just wanted to check what your thoughts were before submitting a patch :) thanks!

@asgrim asgrim changed the title [Question] [Question] Best way to implement nullable types Apr 17, 2017
@jaapio
Copy link
Member

jaapio commented Apr 24, 2017

The type itself doesn't have to change for this. A Nullable type to wrap the actual type seems to be the right way to implement this.

Looking forward to your patch 👍

@asgrim
Copy link
Contributor Author

asgrim commented Apr 24, 2017

Excellent thanks - will work on this shortly!

@asgrim asgrim changed the title [Question] Best way to implement nullable types PHP 7.1 compatibility - Implement Nullable types Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants