Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

password_hash()/password_verify() functions should support yescrypt #12911

Open
hannob opened this issue Dec 9, 2023 · 2 comments · May be fixed by #16452
Open

password_hash()/password_verify() functions should support yescrypt #12911

hannob opened this issue Dec 9, 2023 · 2 comments · May be fixed by #16452
Assignees
@nielsdos
Labels
Extension: standard Feature

Comments

@hannob
Copy link

hannob commented Dec 9, 2023

Description

Many Linux distributions are moving towards using the yescrypt hash function as a modern hash function for system authentication (it's the default in latest versions of Fedora, Debian, Ubuntu).

PHP's password_hash()/password_verify() functions currently do not support yescrypt. It can be used with crypt() when php is compiled with --with-external-libcrypt which is currently not the default. However, the semantics of crypt() are complicated, and the docs for the crypt() function encourage the use of password_hash(). Therefore, it'd be good if password_hash() would support yescrypt.
@bukka
Copy link
Member

bukka commented Dec 9, 2023

This is a reasonable feature request. Just needs someone to create the PR... :)

@nielsdos
Copy link
Member

FWIW, I've started working on this. So far I locally have added support for yescrypt in our crypt() handler when using non-system crypt(). Next up is adding support in password_hash (which uses crypt() for handling the hashes).

@nielsdos nielsdos self-assigned this Oct 11, 2024
@nielsdos nielsdos linked a pull request Oct 15, 2024 that will close this issue
Draft
@nielsdos nielsdos linked a pull request Oct 15, 2024 that will close this issue
Add Yescrypt support to crypt() and password API #16452
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielsdos nielsdos

Labels
Extension: standard Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Yescrypt support to crypt() and password API nielsdos/php-src
3 participants
@bukka @hannob @nielsdos