Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string-variable production rule not used? #237

Open
nbloomf opened this issue Mar 30, 2019 · 1 comment
Open

string-variable production rule not used? #237

nbloomf opened this issue Mar 30, 2019 · 1 comment

Comments

@nbloomf
Copy link

nbloomf commented Mar 30, 2019

In the grammar, the string-variable production rule is not used.

Looking at https://github.com/php/php-src/blob/0720313bd452adf451173574e97fd761f90623a2/Zend/zend_language_parser.y#L1223, I think it should be a summand of dq-char.
@nikic
Copy link
Member

nikic commented Mar 30, 2019

Should probably be in both dq-char and hd-char.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikic @nbloomf