Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL connections to gearmand #9

Open
esabol opened this issue Aug 22, 2021 · 11 comments
Open

Add support for SSL connections to gearmand #9

esabol opened this issue Aug 22, 2021 · 11 comments

Comments

@esabol
Copy link
Contributor

esabol commented Aug 22, 2021

See wcgallego/pecl-gearman#72 for a patch. Any thoughts? I could rebase and submit a PR....

@esabol
Copy link
Contributor Author

esabol commented Sep 24, 2021

Hello? Is there a maintainer around?

@esabol
Copy link
Contributor Author

esabol commented Dec 30, 2021

@oleg-st, any thoughts on this?

@oleg-st
Copy link
Contributor

oleg-st commented Dec 31, 2021

@esabol I do not mind, but I am not a maintainer :)

@esabol
Copy link
Contributor Author

esabol commented Dec 31, 2021

@esabol I do not mind, but I am not a maintainer :)

Ah, I thought you were. Sorry, I misread the commits.

@esabol
Copy link
Contributor Author

esabol commented May 21, 2024

Is anyone interested in this feature? I'd love to collaborate with someone on incorporating my very outdated branch of the old repository into this repository.

@esabol
Copy link
Contributor Author

esabol commented Oct 10, 2024

Well, I think I've finally done it. Before I submit a PR, could someone look over my changes on adding support for the setSSL() method?

esabol@b1abea9

It works perfectly in my testing using my gearmand server with SSL turned on.

I've added some tests to the test suite, but they only test the method with setSSL set to false. I think it would be rather difficult to test otherwise in most scenarios. Not all libgearman.so's are compiled with SSL support for one.

@esabol
Copy link
Contributor Author

esabol commented Oct 10, 2024

I just noticed that gearman_arginfo.h has a comment that says:

/* This is a generated file, edit the .stub.php file instead.

Well, I already edited gearman_arginfo.h. Oops. How do I properly generate the gearman_arginfo.h from the gearman.stub.php file?

@oleg-st
Copy link
Contributor

oleg-st commented Oct 10, 2024

@esabol Use make or make gearman_arginfo.h or php build/gen_stub.php gearman.stub.php

@esabol
Copy link
Contributor Author

esabol commented Oct 10, 2024

@oleg-st wrote:

Use make or make gearman_arginfo.h or php build/gen_stub.php gearman.stub.php

Thanks, Oleg! I went with make gearman_arginfo.h. The generated gearman_arginfo.h has a lot of differences compared to the version in the repo though. That would seem to indicate errors in the gearman.stub.php file, no? What am I supposed to do about those with regards to the PR I'm working on? It sure seems like people have been editing gearman_arginfo.h manually.

@oleg-st
Copy link
Contributor

oleg-st commented Oct 11, 2024

I think gearman.stub.php was changed here #24

@esabol
Copy link
Contributor Author

esabol commented Oct 11, 2024

@oleg-st wrote:

I think gearman.stub.php was changed here #24

Yeah, and that PR neglected to update gearman_arginfo.h, so here we are, I guess. There are a fair number of discrepancies between the two files.

make gearman_arginfo.h fails on PHP 8.4. It complains about the following:

In gearman.stub.php:
GearmanClient::addServer(): Parameter host has null default, but is not nullable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants