-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SSL connections to gearmand #9
Comments
Hello? Is there a maintainer around? |
@oleg-st, any thoughts on this? |
@esabol I do not mind, but I am not a maintainer :) |
Ah, I thought you were. Sorry, I misread the commits. |
Is anyone interested in this feature? I'd love to collaborate with someone on incorporating my very outdated branch of the old repository into this repository. |
Well, I think I've finally done it. Before I submit a PR, could someone look over my changes on adding support for the It works perfectly in my testing using my gearmand server with SSL turned on. I've added some tests to the test suite, but they only test the method with setSSL set to false. I think it would be rather difficult to test otherwise in most scenarios. Not all libgearman.so's are compiled with SSL support for one. |
I just noticed that
Well, I already edited |
@esabol Use |
@oleg-st wrote:
Thanks, Oleg! I went with |
I think |
@oleg-st wrote:
Yeah, and that PR neglected to update
|
See wcgallego/pecl-gearman#72 for a patch. Any thoughts? I could rebase and submit a PR....
The text was updated successfully, but these errors were encountered: