From a6d4f6f9274eeab11f06f6a43f4fc453f7664063 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Wed, 27 Mar 2024 18:24:43 +0100 Subject: [PATCH] GH Actions: run tests also on Windows OS When running the tests locally, I realized that patch 146 did not actually work correctly on Windows. This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs. Note: the lowest PHP version I can get a running build on is PHP 5.5. This is related to SSL transport issues with Packagist with old Composer versions (which are needed for old PHP versions). --- .github/workflows/test.yml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 24a750b..8b69d3f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -91,8 +91,8 @@ jobs: path: ./parallel-lint.phar test: - name: Run tests on PHP ${{ matrix.php }} - runs-on: ubuntu-latest + name: Run tests on PHP ${{ matrix.php }} (${{ matrix.os }}) + runs-on: "${{ matrix.os }}" continue-on-error: ${{ matrix.php == '8.4' }} needs: - bundle @@ -114,6 +114,19 @@ jobs: - '8.2' - '8.3' - '8.4' + os: + - 'ubuntu-latest' + + include: + # Also run the tests against Windows on a few PHP versions. + - php: '5.5' + os: 'windows-latest' + - php: '7.0' + os: 'windows-latest' + - php: '8.0' + os: 'windows-latest' + - php: '8.3' + os: 'windows-latest' steps: - name: Checkout code