Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib agent #61

Closed
mbalandis opened this issue Jan 28, 2019 · 1 comment · Fixed by #76
Closed

Lib agent #61

mbalandis opened this issue Jan 28, 2019 · 1 comment · Fixed by #76
Assignees
Labels

Comments

@mbalandis
Copy link

mbalandis commented Jan 28, 2019

in version 2.2.0
in the src agent still tells it is 1.9

const USER_AGENT = 'PHP Curl/1.9 (+https://github.com/php-mod/curl)';

It is not a bug, however, when I tail logs I wanted to check if it updated correctly but it cannot be checked by this. Maybe it just need a change to

const USER_AGENT = 'PHP Curl/2.0 (+https://github.com/php-mod/curl)';

Also just to confirm, no breaking changes were made (except for php 5.5 removal of course) when transitioning from 1.* to 2.* ? Will nothing breaking gonna be changed continuing with 2.* ? I would suggest jump to 3.* if something breaking gonna be done. Let me know if there is something I need to keep an eye out.

Thanks :)

@nadar nadar self-assigned this Feb 2, 2021
@nadar
Copy link
Member

nadar commented Feb 2, 2021

I will take care of the user agent version. Also the library follows semver and should only contain breaks when releasing major versions.

@nadar nadar added the bug label Feb 2, 2021
@nadar nadar mentioned this issue Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants