-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output causes composer to "report" errors #307
Comments
Composer seems to be flushing everything out of STDERR instead of STDOUT (at least that's how it seems to be picked up). As both are currently handled in an identical way, I suppose I could make the message somewhat less alarming 😄. |
If that's true, we should report it to composer. |
I agree; it sounds like a bug, though I wouldn't expect something as large and popular as Composer to still be bugged in that regard, so I did some research and apparantly my hunch was right: they did it on purpose. Seeing as this is the case, I'll remove the |
@Gert-dev Can you use status code to detect failure/success instead? |
@umpirsky Thanks for the tip. That should already be the case. If the exit code is non-zero, a promise is rejected, causing an error message to be shown in Atom ("Core installation failed") rather than the message that the core was installed successfully. |
Even when successfully installed, it says
Composer has errors to report
:The text was updated successfully, but these errors were encountered: