-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call tips - Way to hide when not mousing over #300
Comments
Inside anonymous functions was one place where I wanted to forcibly disable the call tip from the function/method call "higher up" (such as in the case you are displaying). Unfortunately, php-parser doesn't allow fetching the body (i.e. the positions of the opening and closing parantheses) separately from the entire closure with all its contained statements, so disabling it would mean you won't get call tips anywhere for the closure (not even on the It's not a solution to the entire problem in this ticket, but it would help minimize annoyance :-). |
This replaces our own implementation with the one from atom-ide-ui. Next to having a consistent UI with other IDE packages and benefitting from improvements made over there, they also offer several advantages over our own implementation: - It is configured here to automatically trigger (!) when the paranthesis is typed. To add to that, it automatically remains open as long as the user continues typing and doesn't move outside the function call. This means it will never pop up automatically unless either typing a new function call or explicitly requesting it. - You can easily close it by pressing escape (#300) or moving outside of the function call, so it gets in the way much less often. - It also displays, next to the active parameter's documentation, the documentation of the function itself (mostly deals with #301). - It displays above the function call, so it doesn't overlap with autocompletion (#311) - You can drag them out of the way. - You can attach keyboard triggers to them. Finally, this code is pretty much ready for use on our end, but there are some minor issues I'd like to see ironed out in atom-ide-ui before releasing this: - The API is currently still experimental - The styling is currently a bit barebones; the name of the active parameter is not displayed. - HTML in descriptions is being escaped (same issue as facebookarchive/atom-ide-ui#99) References #300 References #301 References #311
I have the same problem. Could it be possible to use ESC key to hide the signature help? It might be useful as a workaround meanwhile atom-ide-ui integration is fully completed :). |
Sounds like a good idea. I've decided to try and merge the ide-ui integration in the upcoming version (I think I can work around the HTML being escaped in the signature help), which supports closing via the escape key :-). |
Great news! Thanks a lot :). |
Closing this as 3.2 has been released. Tooltips as well as signature help now use atom-ide-ui's implementation, so they can be closed with the escape key and are a lot better at not getting in your way in general :-). |
Originally posted by @mrthebob (https://github.com/php-integrator/atom-call-tips-legacy-php56/issues/12)
Comment 1 (Gert-dev)
Comment 2 (mrthetbob)
Comment 3 (Gert-dev)
Comment 4 (mrthebob)
Comment 5 (Gert-dev)
Comment 6 (mrthebob)
The text was updated successfully, but these errors were encountered: