Getting applyMask to work #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the white parts of the mask stay visible and the black parts disappear ? While this seems to fix applyMask(), the mask seems to be applied backwards. The following seems more appropriate: Using $blackAmount: Using $whiteAmount: |
|
"Reflection" example states that white is transparent, in other words, blacks stay and whites dissolve.
|
|
I guess I can only curse at the lack of standardisation regarding image masking. This really feels counter-intuitive. |
|
Found this fix really usefull, should be merged |
|
Does this resolve the bug that |
| @@ -376,7 +376,8 @@ public function applyMask(ImageInterface $mask) | |||
| $position = new Point($x, $y); | |||
| $color = $this->getColorAt($position); | |||
| $maskColor = $mask->getColorAt($position); | |||
| $round = (int) round(max($color->getAlpha(), (100 - $color->getAlpha()) * $maskColor->getRed() / 255)); | |||
| $blackAmount = 1 - ($maskColor->getValue(ColorInterface::COLOR_RED) + $maskColor->getValue(ColorInterface::COLOR_GREEN) + $maskColor->getValue(ColorInterface::COLOR_BLUE)) / 3 / 255; | |||
There was a problem hiding this comment.
This should be tested
This was referenced Feb 9, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not make GD\Image::applyMask() to work as described in Reflection example in http://www.slideshare.net/avalanche123/introduction-toimagine so I made some fixes.